chore: env updates #288
chore: env updates #288
Conversation
* debug: vercel install scripts * debug: vercel install scripts * chore: default to dev env * debug: node-gyp dependency (#285) * debug: node-gyp dependency * debug: restore contracts * chore: remove hardhat from bun workspace * chore: update app-env package * chore: update dependencies
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request updates the environment configurations for the smartsale project. The changes include modifying the File-Level Changes
Tips
|
|
Caution Review failedThe pull request is closed. WalkthroughThe recent updates primarily focus on version upgrades for various dependencies across different applications within the project. These changes include locking certain packages to specific versions, incrementing others to newer versions, and introducing new environment configurations. This maintenance effort enhances compatibility, introduces new features, and ensures the development environment is flexible for testing and feature toggling. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Environment
participant DependencyManager
Developer->>Environment: Set environment variables
Environment->>DependencyManager: Check for updated dependencies
DependencyManager-->>Environment: Returns updated versions
Environment->>Developer: Confirms updates and configuration
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @gaboesquivel - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the commented-out Supabase configuration in the 'test' environment or provide a clear explanation for why it's kept.
- Please add a brief comment explaining the expansion of the 'usdt' array in the production environment. Why are all these contracts needed?
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -31,7 +31,7 @@ const prod: SmartsaleEnvConfig = { | |||
| auction: "0x", | |||
| bk: "launchpad.bk", | |||
| }, | |||
| usdt: [EOSUSDT], | |||
| usdt: [EOSUSDT,...usdcContracts, ...usdtContracts], | |||
There was a problem hiding this comment.
issue (bug_risk): Potential issue with spread operator usage.
Ensure that usdcContracts and usdtContracts are arrays. If they are not, this could lead to unexpected behavior.
| @@ -41,7 +41,6 @@ const dev: SmartsaleEnvConfig = { | |||
| }, | |||
| chains: smartsaleChains.dev, | |||
| esrCallbackUrl: "https://dev.bitlauncher.ai/api/esr", | |||
| // esrCallbackUrl: "https://192.168.23.3:3000/api/esr", | |||
There was a problem hiding this comment.
suggestion: Consider removing commented-out code.
Leaving commented-out code can clutter the codebase and make it harder to maintain. If this line is no longer needed, consider removing it entirely.
| // esrCallbackUrl: "https://192.168.23.3:3000/api/esr", | |
| }, | |
| chains: smartsaleChains.dev, | |
| esrCallbackUrl: "https://dev.bitlauncher.ai/api/esr", | |
| issuer: { | |
| eos: "gaboesquivel", |
| usdt: [EOSFakeBITUSD, EOSFakeUSDT, SepoliaUSDT, TestnetUSDT, ...usdcContracts, ...usdtContracts], | ||
| }; | ||
|
|
||
| // pre production tests |
There was a problem hiding this comment.
suggestion: Unclear comment.
The comment // pre production tests is vague. If it is necessary, consider making it more descriptive or removing it if it does not add value.
| // pre production tests | |
| /** | |
| * Configuration for pre-production testing environment. | |
| * This includes settings and contracts for testing purposes. | |
| */ |
| @@ -0,0 +1,11 @@ | |||
| # app-env | |||
|
|
|||
| This package manages the environment configurations for the smartsale project, covering production, pre-production, and development settings. | |||
There was a problem hiding this comment.
suggestion (documentation): Consider capitalizing 'smartsale' to 'SmartSale'.
It might be a proper noun or brand name, so capitalizing it could be more appropriate.
| This package manages the environment configurations for the smartsale project, covering production, pre-production, and development settings. | |
| This package manages the environment configurations for the SmartSale project, covering production, pre-production, and development settings. |
| ## Environments | ||
|
|
||
| - **Production (prod)**: [bitlauncher.ai](https://bitlauncher.ai) - Mainnet auction contracts with real tokens. | ||
| - **Pre-Production (test)**: [test.bitlauncher.ai](https://test.bitlauncher.ai) - Mainnet pre-prod auction contracts with real tokens. |
There was a problem hiding this comment.
suggestion (documentation): Consider changing 'pre-prod' to 'pre-production' for consistency.
Using 'pre-production' instead of 'pre-prod' would maintain consistency with the rest of the document.
| - **Pre-Production (test)**: [test.bitlauncher.ai](https://test.bitlauncher.ai) - Mainnet pre-prod auction contracts with real tokens. | |
| **Pre-Production (test)**: [test.bitlauncher.ai](https://test.bitlauncher.ai) - Mainnet pre-production auction contracts with real tokens. |
Summary by Sourcery
This pull request updates the environment configurations by adding new USDT and USDC contracts to the production settings and simplifying the test settings. It also removes the canary environment configuration and adds documentation for the environment settings.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores